Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Migrates the log service to the “new fibers” service pattern (scopes + standard start(conn, opts) entrypoint), updates runtime/bus behavior accordingly, and adds a spec + service-level tests to validate published bus messages and lifecycle states.
Changes:
- Refactors
services.loginto a fibers-scope-driven singleton that publishes{'logs', <level>}entries and retains{'svc', <name>, 'status'}lifecycle status. - Adds comprehensive LuaUnit tests covering singleton behavior, bus publishing, and lifecycle start/stop.
- Introduces
docs/specs/log.mddocumenting levels, bus message shapes, and lifecycle flow.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
src/services/log.lua |
Refactors log service to fibers scopes, standard start(conn, opts) signature, bus publish/retain behavior |
tests/test_log.lua |
Adds service-level tests for log singleton methods, bus publishing, and lifecycle retained status |
docs/specs/log.md |
Adds a log service specification describing API, topics, payloads, and lifecycle |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
rslater-cs
force-pushed
the
log-migration
branch
from
6e06a9a to
e57b98f
Compare
rslater-cs
force-pushed
the
hal-migration
branch
from
f1d7152 to
7ed23da
Compare
rslater-cs
force-pushed
the
log-migration
branch
from
e57b98f to
0e7c1ec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Keeps same features as previous log service but using fiber scopes, changing endpoints to fit the runtime proposal and adds tests for checking bus messages and that all modes exist. Check the log spec for more detail.
Manual test
Manual test description
copy the code over to a box and run
DEVICECODE_CONFIG_DIR=./configs/ DEVICECODE_SERVICES=config,hal,gsm,log luajit main.luaAdded tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?